Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary testing: Fix cleanup of temporary directories #378

Merged
merged 2 commits into from
Apr 6, 2020

Conversation

kmoe
Copy link
Member

@kmoe kmoe commented Apr 3, 2020

Fix a bug in which temporary directories created during a binary test run were not cleaned up at the end of the run.

@kmoe kmoe requested a review from a team April 3, 2020 20:04
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please PR the fix into version2 as well!

@kmoe kmoe merged commit b8e75fe into master Apr 6, 2020
@kmoe kmoe deleted the binary-acctests-tidy-up-tmpdirs branch April 6, 2020 16:23
@appilon
Copy link
Contributor

appilon commented Apr 16, 2020

@kmoe friendly reminder to recreate the codechange (don't bring along changelog) to V2

@ghost
Copy link

ghost commented May 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants